mneethiraj commented on code in PR #1297: URL: https://github.com/apache/ranger/pull/1297#discussion_r4288355005
########## tagsync/scripts/install.properties: ########## @@ -29,6 +29,10 @@ TAG_SOURCE_ATLAS_KAFKA_BOOTSTRAP_SERVERS=localhost:6667 TAG_SOURCE_ATLAS_KAFKA_ENTITIES_GROUP_ID=ranger_entities_consumer TAG_SOURCE_ATLAS_KAFKA_SERVICE_NAME=kafka TAG_SOURCE_ATLAS_KAFKA_SECURITY_PROTOCOL=PLAINTEXTSASL +# SASL mechanism for the Atlas Kafka consumer; supported values: OAUTHBEARER (token) and GSSAPI (Kerberos keytab) +TAG_SOURCE_ATLAS_KAFKA_SASL_MECHANISM=OAUTHBEARER Review Comment: Given Kerberos authentication is used currently, shouldn't the default be GSSAPI? ########## agents-audit/kafka-client-auth/pom.xml: ########## @@ -0,0 +1,59 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> Review Comment: Why is `kafka-client-auth` module under `agents-audit`? I suggest moving to a top-level module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
