ChinmayHegde24 commented on code in PR #1307:
URL: https://github.com/apache/ranger/pull/1307#discussion_r4296229622
##########
functional-tests/xuserrest/test_utility_fun.py:
##########
@@ -285,6 +286,21 @@ def test_get_auth_session_info_success(self, role, auth):
expected_user = auth[0]
assert data.get("loginId") == expected_user, f"Expected loginId to be
{expected_user} but got {data.get('loginId')}"
assert data.get("id") is not None
+
Review Comment:
functional-test looks unnecessary here as unit test correctly tests single
line fix,
and also the test here is not catching the bug i.e it runs against a
container whose JVM defaults to an English locale by default (en_US.UTF-8)
I verified by using this command `docker exec ranger bash -c 'cat
/etc/locale.conf 2>/dev/null || locale'`
so it will pass on the unfixed prior code as well, so I suggest you to
remove the whole test and utils added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
