fimugdha commented on code in PR #1375:
URL: https://github.com/apache/ranger/pull/1375#discussion_r4614508753


##########
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx:
##########
@@ -151,7 +151,8 @@ function XATableLayout({
                 <IndeterminateCheckbox {...row.getToggleRowSelectedProps()} />
               </div>
             ),
-            width: 40
+            width: 40,
+            disableResizing: true

Review Comment:
   lets add comment over here why we need disableResizing: true over here for 
this particular column cell.



##########
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx:
##########
@@ -345,23 +346,25 @@ function XATableLayout({
                             column.toggleSortBy(!column.isSortedDesc)
                           }
                         >
-                          {columnResizable && !column.disableResizing && (
-                            <>
-                              <div
-                                className="fa fa-expand"
-                                aria-hidden="true"
-                                {...column.getResizerProps([
-                                  { className: "resizer" }
-                                ])}
-                                onClick={(event) => event.stopPropagation()}
-                              />
-                              <i
-                                className="fa fa-expand resizeable-icon"
-                                aria-hidden="true"
-                                {...column.getResizerProps()}
-                              />
-                            </>
-                          )}
+                          {columnResizable &&

Review Comment:
   Kindly add comment on the introduction of the new check : 
`column.hideResizer` and it purpose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to