----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34787/#review85643 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 28, 2015, 10:55 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34787/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 10:55 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-513 > https://issues.apache.org/jira/browse/RANGER-513 > > > Repository: ranger > > > Description > ------- > > A bug in resource hierarhies detection code was skipping certain validation > of resources, e.g. valid resource types, of recursive flags etc. This > happened any service-def that had only single level hierarchies, e.g. HDFS or > KMS. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > 91ff16a > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefHelper.java > 2703384 > > Diff: https://reviews.apache.org/r/34787/diff/ > > > Testing > ------- > > Testing that rest service will now flag an HDFS policy which has an invalid > resource name in it. > New junit added to catch this specific bug. > > > Thanks, > > Alok Lal > >
