----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36961/#review93670 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationErrorCode.java (line 20) <https://reviews.apache.org/r/36961/#comment148087> Move error catalog to a wider package, like org.apache.ranger.plugin.errors. This can be used to consolidate all user visible errors from the plugins. agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationErrorCode.java (line 32) <https://reviews.apache.org/r/36961/#comment148086> It will be helpful to use a more descriptive name for the enum. For example, SERVICE_VALIDATION_ERR_UNSUPPORTED_ACTION would be easier to read instead of SERVICE_VALIDATION_ERR_01. agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationErrorCode.java (line 61) <https://reviews.apache.org/r/36961/#comment148083> Consider using MessageFormat to format the message. - Madhan Neethiraj On July 30, 2015, 11:06 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36961/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 11:06 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-584 > https://issues.apache.org/jira/browse/RANGER-584 > > > Repository: ranger > > > Description > ------- > > Service validation: Provide user friendly error messages about validation > failures > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > 615e385 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationErrorCode.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestValidationErrorCode.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36961/diff/ > > > Testing > ------- > > new tests, existing tests > > > Thanks, > > Alok Lal > >
