----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38037/#review97388 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesAccessedTogetherCondition.java (line 76) <https://reviews.apache.org/r/38037/#comment153277> Please review all log messages. Some are identical to RangerHiveResourcesNotAccessedTogetherCondition. agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java (line 212) <https://reviews.apache.org/r/38037/#comment153282> This comment may be removed. - Abhay Kulkarni On Sept. 2, 2015, 2:40 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38037/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 2:40 a.m.) > > > Review request for ranger and Abhay Kulkarni. > > > Bugs: RANGER-274 > https://issues.apache.org/jira/browse/RANGER-274 > > > Repository: ranger > > > Description > ------- > > fixed excessive log by plugin on receiving no-tag-change from Ranger admin; > added condition to check context-attribute value in the condition values; > replaced @SuppressWarnings with type safe code; misc log message fixes > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 7420830 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 35d0731 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerContextAttributeValueInCondition.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesAccessedTogetherCondition.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesNotAccessedTogetherCondition.java > 0f44bba > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java > 418021c > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptTemplateConditionEvaluator.java > a4fd129 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java > ccb78f6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > dfc07db > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 63ae385 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > a617e70 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestedResources.java > 19456c5 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 969e7d7 > agents-common/src/test/resources/policyengine/test_policyengine_hdfs.json > d5df5e2 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > 47bf2a0 > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java c0241b2 > > Diff: https://reviews.apache.org/r/38037/diff/ > > > Testing > ------- > > Verified that existing tests pass > > > Thanks, > > Madhan Neethiraj > >
