> On Sept. 1, 2015, 9:14 p.m., Madhan Neethiraj wrote: > > the review has only one file. This does not look right, given this is a > > back port of a number of commits. Can you check the patch/review?
This change only affected one file. It can be confirmed from the old review for commit to master given above. - Alok ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38022/#review97396 ----------------------------------------------------------- On Sept. 1, 2015, 3:52 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38022/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 3:52 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-551 > https://issues.apache.org/jira/browse/RANGER-551 > > > Repository: ranger > > > Description > ------- > > Following 5 commits from master need to be applied to 0.5 branch so that work > on RANGER-632, RANGER-633 and RANGER-634 can be done. (Please refer to bash > transcript below for details) > - This review ports RANGER-551 from master to 0.5 > - Thus review is the same as [its original > review](https://reviews.apache.org/r/35407/) > > ```bash > alal$ git merge-base ranger-0.5 master > b70ec703ad34e4c4996b7ba5a41a233d338297da > > alal$ git log --oneline --author='Alok Lal' -i --grep validation > b70ec703ad34e4c4996b7ba5a41a233d338297da~1..ranger-0.5 > > alal$ git log --oneline --author='Alok Lal' -i --grep validation > b70ec703ad34e4c4996b7ba5a41a233d338297da~1..master > 79bd7e3 RANGER-594 User friendly error messages for policy validation error > failures and unify error processing for all 3 types validations > 2d931db RANGER-593 User friendly error messages for service def validation > error failures > d1e2f3b RANGER-584 User friendly error messages for service validation error > failures > e35e1c1 RANGER-560 Policy validation: user friendly error messages about > validation failures > eb01a1d RANGER-551 Policy Validation: If resource levels are not valid for > any hierarchy then checks about missing mandatory levels should be skipped > > alal$ > ``` > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > d27b667 > > Diff: https://reviews.apache.org/r/38022/diff/ > > > Testing > ------- > > Build and existing junits work. > > > Thanks, > > Alok Lal > >
