-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38708/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay
Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-663
https://issues.apache.org/jira/browse/RANGER-663
Repository: ranger
Description
-------
Added @Version annotation to JPA entities for service-def/service/policy, which
ensures updates on entities that are committed by another trx do not succeed
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
6813915
security-admin/src/main/java/org/apache/ranger/entity/XXPolicyBase.java
7e59530
security-admin/src/main/java/org/apache/ranger/entity/XXServiceBase.java
9fc7349
security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java
93a0372
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f523d67
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
dac9807
security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java
d0ddcff
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java
b2fdad6
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
f728c58
security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java
bac5261
security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java
94680c3
security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java
dd1978b
security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceService.java
7d0cf61
security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceServiceBase.java
f359118
Diff: https://reviews.apache.org/r/38708/diff/
Testing
-------
Reproduced the issue by updating a policy simultaneously by 2 clients using
REST API. With this fix, verified that only one of such simultaneous updates
succeed.
Thanks,
Madhan Neethiraj
