----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38709/#review100404 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Sept. 24, 2015, 7:26 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38709/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 7:26 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-661 > https://issues.apache.org/jira/browse/RANGER-661 > > > Repository: ranger > > > Description > ------- > > Updated policy-download to return error, instead of empty policy-list, on > failure in retrieving policies from DB > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > d62c645 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 70e89a3 > > Diff: https://reviews.apache.org/r/38709/diff/ > > > Testing > ------- > > - verified that on error in retrieving policies from DB, policy-download API > returns 400 (instead of 200 with empty policy list). With this fix, the > plugin will continue to use the cached policies (instead of using empty > policy list). > > > Thanks, > > Madhan Neethiraj > >
