----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38917/#review101303 -----------------------------------------------------------
agents-common/scripts/enable-agent.sh (line 127) <https://reviews.apache.org/r/38917/#comment158678> Use pattern "^CUSTOM_USER[ \t]*=" to avoid reading other properties like 'CUSTOM_USER_NAME'. Why not use $(getInstallProperty 'CUSTOM_USER')? And please fix that method as well for the above comment. agents-common/scripts/enable-agent.sh (line 147) <https://reviews.apache.org/r/38917/#comment158679> Replace this "elif" with "else" - it will be easier to read. security-admin/scripts/setup.sh (line 1533) <https://reviews.apache.org/r/38917/#comment158680> Wouldn't this replace both LINUX_USER and MOD_NAME in initd file? Please review. LINUX_USER=ranger BIN_PATH=/usr/bin MOD_NAME=ranger-admin - Madhan Neethiraj On Oct. 1, 2015, 10:56 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38917/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 10:56 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan > Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-673 > https://issues.apache.org/jira/browse/RANGER-673 > > > Repository: ranger > > > Description > ------- > > Patch contains changes which allows Ranger Admin, Ranger Usersync and Ranger > KMS to be manually installed using custom user. It also has changes which > will allow plugins to work with custom user if component is installed using > custom user (manually). > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh > 55130a59996115f8793e85571a5cc2d360d7705e > hbase-agent/scripts/install.properties > 9170f41ea9d69925fde9a04a089fdeb2e40494a9 > hdfs-agent/scripts/install.properties > 289117badc160be01087487e83aeb494fb76ce7f > hive-agent/scripts/install.properties > 93706006c1942d9efbafb49e13da4be3b015efe6 > kms/scripts/setup.sh e0c3136cbc39803c0771187eddde94b69d3146f6 > knox-agent/scripts/install.properties > 2fee7eea04a30da45861f0370408cfe63a664d25 > plugin-kafka/scripts/install.properties > 1e2854eb936d71b4b06cce400374ec1b69cc527f > plugin-kms/scripts/enable-kms-plugin.sh > 53187f75b9e3966c09cf24fbb96d0b14a10a7fc9 > plugin-solr/scripts/install.properties > 1f3852e4d33a151406328c7de7de0562b1f55f53 > plugin-yarn/scripts/install.properties > 93580339257b28662df6d6a25fdbab3937f9e0d7 > security-admin/scripts/set_globals.sh > 2c00aedf0725d95e822236d4af8bb01aa1dd4c5e > security-admin/scripts/setup.sh 71c424c28a0eba6c3f547da9b13fe667ea15e3ec > storm-agent/scripts/install.properties > 0cee6554d3a8de3071434ef1821b94b88192b6eb > unixauthservice/scripts/set_globals.sh > c77fbf9b4355a8e4c6b0bf5ed8d5be4c73136e12 > unixauthservice/scripts/setup.py 5ba50d374f77eac5a7b0746788e434dcad028092 > > Diff: https://reviews.apache.org/r/38917/diff/ > > > Testing > ------- > > Tested following scenarios > > 1) Installed Ranger services using custom user on centos6, suse instance > 2) Installed HDFS, Hbase, Hive, Knox, Storm, Kafka, Yarn using custom user > and manually enabled plugin and verified enforcements after enabling plugin. > > > Thanks, > > Gautam Borad > >
