----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39029/#review101608 -----------------------------------------------------------
Ship it! security-admin/contrib/audit_hdfs_folders/create_hdfs_folders_for_audit_secure.sh (line 26) <https://reviews.apache.org/r/39029/#comment159040> if KMS_USER_GROUP is the only difference between the scripts for secure and simple-auth environments, it might be useful to have a single script that takes an argument. Please consider this suggestion. - Madhan Neethiraj On Oct. 6, 2015, 4:50 a.m., Don Bosco Durai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39029/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 4:50 a.m.) > > > Review request for ranger, Gautam Borad, Madhan Neethiraj, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-173 > https://issues.apache.org/jira/browse/RANGER-173 > > > Repository: ranger > > > Description > ------- > > There are 2 scripts now. One for secure and other for non-secure. The reason > being, in secure mode Ranger KMS logs audit as user HTTP and in non-secure > mode it logs audit as user kms > > > Diffs > ----- > > > security-admin/contrib/audit_hdfs_folders/create_hdfs_folders_for_audit_non_secure.sh > PRE-CREATION > > security-admin/contrib/audit_hdfs_folders/create_hdfs_folders_for_audit_secure.sh > PRE-CREATION > > Diff: https://reviews.apache.org/r/39029/diff/ > > > Testing > ------- > > Tested manually on both secure and non-secure mode > > > Thanks, > > Don Bosco Durai > >
