> On Dec. 9, 2015, 4:56 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java, > > line 412 > > <https://reviews.apache.org/r/41121/diff/1/?file=1156860#file1156860line412> > > > > Are all annotations required or only > > JsonIgnoreProperties(ignoreUnknown=true) is sufficient?
Do you see any harm in adding all the annotations used in outer classes? - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41121/#review109541 ----------------------------------------------------------- On Dec. 9, 2015, 7:51 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41121/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 7:51 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-775 > https://issues.apache.org/jira/browse/RANGER-775 > > > Repository: ranger > > > Description > ------- > > Added ignoreUnknown=true annotation to classes used in REST API > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > fb5383c > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > cd69320 > > Diff: https://reviews.apache.org/r/41121/diff/ > > > Testing > ------- > > Verified that earlier version of the plugin, with this patch, successfully > handles the policies downloaded from latest version of ranger-admin. > > > Thanks, > > Madhan Neethiraj > >
