[ 
https://issues.apache.org/jira/browse/RANGER-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117953#comment-15117953
 ] 

rangerqa commented on RANGER-821:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12784484/821.final.patch
  against master revision 9475c0f.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-RANGER-Build/19//testReport/
Console output: https://builds.apache.org/job/PreCommit-RANGER-Build/19//console

This message is automatically generated.

> Audit shutdown hook should not only do its processing interruptibly but also 
> have an upper bound on how long it runs
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: RANGER-821
>                 URL: https://issues.apache.org/jira/browse/RANGER-821
>             Project: Ranger
>          Issue Type: Bug
>          Components: audit
>            Reporter: Alok Lal
>            Assignee: Alok Lal
>         Attachments: 821.final.patch
>
>
> Ranger audit framework installs a shutdown hook which attempts to flush any 
> pending audit messages (in the async audit queue) to respective audit sinks.  
> There have been issues reported from field that in this shutdown hook can 
> hold up graceful shutdown of its host service.  In some cases this inability 
> to shutdown in a timely manner can interfere with the host services' HA 
> guarantees, e.g. Namenodes HA relies on it to shutdown itself gracefully so 
> standby can takeover.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to