----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40864/#review117262 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Dec. 4, 2015, 3:32 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40864/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 3:32 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan > Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-760 > https://issues.apache.org/jira/browse/RANGER-760 > > > Repository: ranger > > > Description > ------- > > Patch contains following changes in Ranger UI code: > > 1. Removed unwanted files and folders > 2. Improved formatting and tab structure > 3. Removed unwanted variables and commented code. > > > Diffs > ----- > > security-admin/src/main/webapp/ajax_failure.jsp b48064c > security-admin/src/main/webapp/ajax_success.html 52023ca > security-admin/src/main/webapp/images/data-grey.png > dabec13279c0d37095b141411848788cb315a800 > security-admin/src/main/webapp/images/database_table_32.png > 14bb068c3c60331c021e5c68b78effcd92b49941 > security-admin/src/main/webapp/images/folder.png > 0613c6bf05befc4ce6700dce0838100fcb95bdb7 > security-admin/src/main/webapp/images/folder2.png > 85da97f546c67f35e487ccd3cb65de5df6135acf > security-admin/src/main/webapp/images/hbase.jpg > 27c177ac5c13990e167120cccf69bcc1d53269f1 > security-admin/src/main/webapp/images/hdfs.jpg > 2f6dad2b0f7056ae5f9333416fdb78b21bca5e22 > security-admin/src/main/webapp/images/hive.png > b7939b13efde8d89db305291c69da5c9492957f3 > security-admin/src/main/webapp/images/hline.png > b488b952d632f5bb078287fb67a09e1312850941 > security-admin/src/main/webapp/images/knox.gif > 3edc8fda8c245e400ac9c7a0ca12be0342937fbe > security-admin/src/main/webapp/images/knox1.png > 56265c73431c6dd3cdcb068d6ab599309f384566 > security-admin/src/main/webapp/images/router-grey.png > 54241399f3fe67da181e0302388ebf8fd6c263cf > security-admin/src/main/webapp/images/storm.png > 510cc920eca6b6a246a1ff0f753718ac8556248a > security-admin/src/main/webapp/images/storm1.png > a5b36c7e50c80ad2e2e1cc16599032c6745ea538 > security-admin/src/main/webapp/images/task-grey.png > 6c7608458d3b55b50bb318d52c1323adfefd1f60 > security-admin/src/main/webapp/index.html f1d0b75 > security-admin/src/main/webapp/login.jsp 0db6882 > > security-admin/src/main/webapp/scripts/collection_bases/VXAuditRecordListBase.js > 1cd1fb1 > security-admin/src/main/webapp/scripts/collections/VXAuditRecordList.js > 09c434a > security-admin/src/main/webapp/scripts/controllers/Controller.js 7b9cc39 > security-admin/src/main/webapp/scripts/model_bases/VXAuditRecordBase.js > fb1e8fb > security-admin/src/main/webapp/scripts/models/VXAuditRecord.js 0e89a7f > security-admin/src/main/webapp/scripts/models/VXGroup.js 3aa3615 > security-admin/src/main/webapp/scripts/models/VXPortalUser.js 079fc9c > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 457b7e8 > security-admin/src/main/webapp/scripts/views/accounts/AccountCreate.js > 75c2967 > > security-admin/src/main/webapp/scripts/views/accounts/AccountDetailLayout.js > f23813f > security-admin/src/main/webapp/scripts/views/accounts/AccountForm.js > 718b9d6 > security-admin/src/main/webapp/scripts/views/accounts/AccountTableLayout.js > 1bb863b > security-admin/src/main/webapp/scripts/views/common/AddGroup.js ecee740 > security-admin/src/main/webapp/scripts/views/common/BreadCrumbs.js c1f2d4b > security-admin/src/main/webapp/scripts/views/common/FormInputItemList.js > ca1ebc4 > security-admin/src/main/webapp/scripts/views/common/TopNav.js 0e7c6e9 > security-admin/src/main/webapp/scripts/views/common/UserPermissionList.js > fce1963 > security-admin/src/main/webapp/scripts/views/common/XABackgrid.js d9cc832 > security-admin/src/main/webapp/scripts/views/common/XATableLayout.js > 12bd6d7 > security-admin/src/main/webapp/scripts/views/folders/FolderInfo.js 18ef7e2 > security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 52990dd > security-admin/src/main/webapp/scripts/views/kms/KmsKeyCreate.js 0bc62b6 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js > 3e03d80 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js > 497a4a2 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js > 18d7c4c > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 42d27b1 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js > cc11cef > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > 55ea285 > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > f7c72dc > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 8491a79 > security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js > 8f0f67e > security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js > 1b66728 > > security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js > b65dff4 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > ac05eba > security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js > 598db83 > security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js > 79d6187 > security-admin/src/main/webapp/scripts/views/service/ServiceForm.js 058a407 > security-admin/src/main/webapp/scripts/views/service/ServiceTableLayout.js > 284135b > security-admin/src/main/webapp/scripts/views/user/UserProfile.js 79ee687 > security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js > b363a10 > security-admin/src/main/webapp/scripts/views/users/GroupCreate.js dca6b13 > security-admin/src/main/webapp/scripts/views/users/UserCreate.js 817831d > security-admin/src/main/webapp/scripts/views/users/UserForm.js 52a278d > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > aeb8608 > security-admin/src/main/webapp/templates/accounts/AccountCreate_tmpl.html > 1fe0fce > > security-admin/src/main/webapp/templates/accounts/AccountDetailLayout_tmpl.html > f0e5c0f > security-admin/src/main/webapp/templates/accounts/AccountForm_tmpl.html > 0a0e560 > > security-admin/src/main/webapp/templates/accounts/AccountTableLayout_tmpl.html > 4d4d14e > security-admin/src/main/webapp/templates/asset/AssetCreate_tmpl.html > 43b7f24 > security-admin/src/main/webapp/templates/asset/AssetForm_tmpl.html 3e24abc > security-admin/src/main/webapp/templates/asset/AssetTableLayout_tmpl.html > 4769039 > security-admin/src/main/webapp/templates/common/Footer_tmpl.html 253202c > > security-admin/src/main/webapp/templates/common/PolicyManagerLayout_tmpl.html > b4f242b > security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html > f124a12 > security-admin/src/main/webapp/templates/common/TopNav_tmpl.html a5bc392 > security-admin/src/main/webapp/templates/common/UserPermissionList.html > 797ae21 > security-admin/src/main/webapp/templates/common/breadcrumbs.html 26d5116 > security-admin/src/main/webapp/templates/common/formInputItem.html b9e4b82 > security-admin/src/main/webapp/templates/common/formInputItemList.html > ff40e5b > security-admin/src/main/webapp/templates/folders/FolderInfo_tmpl.html > 741623f > security-admin/src/main/webapp/templates/hbase/HbasePolicyCreate_tmpl.html > 954f3f5 > security-admin/src/main/webapp/templates/hbase/HbasePolicyForm_tmpl.html > fdd5f47 > security-admin/src/main/webapp/templates/hbase/HbaseTableLayout_tmpl.html > 109b9d2 > security-admin/src/main/webapp/templates/hdfs/HDFSTableLayout_tmpl.html > a0b2780 > security-admin/src/main/webapp/templates/hdfs/PolicyCreate_tmpl.html > eab1c22 > security-admin/src/main/webapp/templates/hdfs/PolicyForm_tmpl.html 7505b78 > security-admin/src/main/webapp/templates/helpers/XAHelpers.js eec7a95 > security-admin/src/main/webapp/templates/hive/HivePolicyCreate_tmpl.html > 69e97d3 > security-admin/src/main/webapp/templates/hive/HivePolicyForm_tmpl.html > 94fa928 > security-admin/src/main/webapp/templates/hive/HiveTableLayout_tmpl.html > 9500c1a > security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 1249aed > security-admin/src/main/webapp/templates/kms/KmsTableLayout_tmpl.html > 8437c04 > security-admin/src/main/webapp/templates/knox/KnoxInfo_tmpl.html 09a6348 > security-admin/src/main/webapp/templates/knox/KnoxPolicyCreate_tmpl.html > 69e97d3 > security-admin/src/main/webapp/templates/knox/KnoxPolicyForm_tmpl.html > 2e31599 > security-admin/src/main/webapp/templates/knox/KnoxTableLayout_tmpl.html > 3369522 > security-admin/src/main/webapp/templates/license/LicenseCreate_tmpl.html > 029b024 > security-admin/src/main/webapp/templates/license/LicenseInfo_tmpl.html > dd7e5ec > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > badb615 > security-admin/src/main/webapp/templates/policies/PermissionList.html > bb96a61 > security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html > 9de3007 > > security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html > 55b0a9e > > security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html > 30b6c60 > > security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html > 7e66fca > > security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html > 376967c > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html > 53be812 > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html > f61e91f > > security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html > 7bed784 > > security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html > 05d9c77 > > security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html > 45c3c59 > security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html > e12ce7f > > security-admin/src/main/webapp/templates/reports/UserUpdateOperationDiff_tmpl.html > 2bce108 > > security-admin/src/main/webapp/templates/service/ConfigurationList_tmpl.html > dbc0d65 > security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html > 587a7c6 > security-admin/src/main/webapp/templates/storm/StormPolicyCreate_tmpl.html > 69e97d3 > security-admin/src/main/webapp/templates/storm/StormPolicyForm_tmpl.html > 4b70327 > security-admin/src/main/webapp/templates/storm/StormTableLayout_tmpl.html > 9e6495d > security-admin/src/main/webapp/templates/user/UserProfileForm_tmpl.html > 8ed5ac6 > security-admin/src/main/webapp/themejs/1.3.0/bootstrap.min.js 935de7a > > Diff: https://reviews.apache.org/r/40864/diff/ > > > Testing > ------- > > Verified normal working of Ranger Admin on master branch. > > 1. Verified CRUD for Services > 2. Verified CRUD for Policies > 3. Verified CRUD for Permission Model > 4. Verified CRUD for Users / Groups > > > Thanks, > > Gautam Borad > >
