----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50464/#review143927 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 28, 2016, 2:29 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50464/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 2:29 a.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-1124: Good coding practices in Ranger recommended by static code > analysis > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > e3e818c > > agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java > 9388914 > > agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java > be9cdd3 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 13607d3 > > Diff: https://reviews.apache.org/r/50464/diff/ > > > Testing > ------- > > This patch contains the fixes for High priority issue. > > CID 150797 150725 150568 95608 > > Tested with local vm for any functionality breakage. > > > Thanks, > > Ramesh Mani > >