----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50573/ -----------------------------------------------------------
Review request for ranger and Velmurugan Periasamy. Bugs: RANGER-1124 https://issues.apache.org/jira/browse/RANGER-1124 Repository: ranger Description ------- RANGER-1124: Good coding practices in Ranger recommended by static code analysis for ugsync, unixauthservice, and unixauthclient modules Diffs ----- ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfigCheckMain.java fe9326f unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java d1107ef unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java acb0b37 Diff: https://reviews.apache.org/r/50573/diff/ Testing ------- This patch contains the fixes for CID #s 131473, 150594, 150789 Tested basic functionality for regression testing. Thanks, Sailaja Polavarapu