----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51229/#review146198 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 19, 2016, 1:18 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51229/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2016, 1:18 a.m.) > > > Review request for ranger, Madhan Neethiraj and Selvamohan Neethiraj. > > > Bugs: RANGER-1155 > https://issues.apache.org/jira/browse/RANGER-1155 > > > Repository: ranger > > > Description > ------- > > Good coding practices in Ranger recommended by static code analysis > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 0012329 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 760c4a3 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java > 50432f7 > > Diff: https://reviews.apache.org/r/51229/diff/ > > > Testing > ------- > > Passed all unit tests and perf-tool tests. > > > Thanks, > > Abhay Kulkarni > >