----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54473/#review159802 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Dec. 7, 2016, 9:02 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54473/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 9:02 a.m.) > > > Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, > and Velmurugan Periasamy. > > > Bugs: RANGER-1242 > https://issues.apache.org/jira/browse/RANGER-1242 > > > Repository: ranger > > > Description > ------- > > #Solution: > In class StormClient, set variable ret to null when function > executeUnderKerberos(). > So funcion connectionTest() of StormClient would find test connection failed. > > > Diffs > ----- > > > storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java > d7415c5 > > Diff: https://reviews.apache.org/r/54473/diff/ > > > Testing > ------- > > #Test case: > Create storm service with error configurations in Ranger Admin with the > following configurations: > *** > name=stormdev > username=storm > password=*** > nimbus.url=http://10.43.159.41:18080 > lookupprincipal=storm/zd...@zdh.com > lookupkeytab=/home/storm/apache-storm-1.0.1/conf/storm.keytab > namerules=RULE:[2:$1@$0]([jt]t@.*ZDH.COM)s/.*/$MAPRED_USER/ > RULE:[2:$1@$0]([nd]n@.*ZDH.COM)s/.*/$HDFS_USER/DEFAULT > *** > then click "TestConnection", the result is connection failed, > and there is failed message in ranger_admin.log? > >2016-12-07 16:04:15,288 [timed-executor-pool-0] DEBUG > >apache.ranger.services.storm.client.StormResourceMgr > >(StormResourceMgr.java:49) - <== StormResourceMgr.validateConfig Result : > >{message=Unable to retrieve any topologies using given parameters., > >connectivityStatus=false, objectId=null, description=Unable to retrieve any > >topologies using given parameters. You can still save the repository and > >start creating policies, but you would not be able to use autocomplete for > >resource names. Check ranger_admin.log for more info., fieldName=null} > > > Thanks, > > Qiang Zhang > >