> On Dec. 22, 2016, 6:28 p.m., Alok Lal wrote: > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java, > > line 235 > > <https://reviews.apache.org/r/54940/diff/1/?file=1590343#file1590343line235> > > > > Small nit: Not everywhere, but at several places ranger code uses > > StringUtils.isEmpty to do such a check.
Thanks, I've fixed that. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54940/#review159987 ----------------------------------------------------------- On Dec. 21, 2016, 4:12 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54940/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 4:12 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1278 > https://issues.apache.org/jira/browse/RANGER-1278 > > > Repository: ranger > > > Description > ------- > > When configuring LDAP authentication, it is required to also specify the > group search base and filter, even though the results are actually discarded. > It should instead be optional to specify the group information. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > 75c4eb0 > > Diff: https://reviews.apache.org/r/54940/diff/ > > > Testing > ------- > > Tested the admin service against LDAP. > > > Thanks, > > Colm O hEigeartaigh > >
