szetszwo commented on a change in pull request #144:
URL: https://github.com/apache/incubator-ratis/pull/144#discussion_r466609264
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -785,7 +785,7 @@ public RaftClientReply
setConfiguration(SetConfigurationRequest request) throws
}
private boolean shouldWithholdVotes(long candidateTerm) {
- if (state.getCurrentTerm() < candidateTerm) {
+ if (state.getCurrentTerm() >= candidateTerm) {
Review comment:
What is the reason behind the change? It seems to contradict the raft
paper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
