It turned out that RaftServerImpl is refactored after Zero-Copy patches, leading to many conflicts to solve. So I decided to include only functional bug fixes and features, while excluding patches on zero-copy / refactor / test improvements, etc. I’ll propose a new release candidate soon.
Best, Ziyang > 2024年6月8日 15:23，Tsz Wo Sze <[email protected]> 写道： > >> I’ll cherry-pick all commits except for the zero copy changes (2a) ... > > Good to know. BTW, please include the recent (non-zero-copy) changes. > Thanks! > > Tsz-Wo > > > On Fri, Jun 7, 2024 at 5:32 AM William Song <[email protected]> wrote: > >> Hi Tsz-Wo, >> >> Thanks very much for the updates. >> >> I’ll cherry-pick all commits except for the zero copy changes (2a) and >> prepare for a new release candidate soon. We can still release a 3.2.0 once >> bugs related to Zero-Copy are fixed. >> >> Btw, Learned a lot from RATIS-2104 ;) >> >> Best, >> William >> >>> 2024年6月6日 17:40，Tsz Wo Sze <[email protected]> 写道： >>> >>> Hi William, >>> >>> I would like to update you on the status of the test failures. >>> >>> RATIS-2104 and RATIS-2108 are probably the same. It could be just a test >>> problem or it could be a real bug in zero copy. We are not yet sure. >> For >>> more details, see the discussion in RATIS-2104. >>> >>> However, RATIS-2105 looks like a real zero copy bug since the test log >> has >>> "IllegalStateException: Failed to release: object has already been >>> completely released". >>> >>> Since you are the release manager, you may consider >>> (1) wait a little longer to see if we could fix the bugs, or >>> (2) cherry-pick the commits in order to exclude the zero copy. Then, I >> can >>> see two choices: >>> (2a) cherry-pick all commits except for the zero copy changes. >>> (2b) cherry-pick only the ccmmits you like to include (bug fixes + some >>> feature you like include). >>> (3) any other way you would like to do. >>> >>> Please see which one works for you the best. >>> >>> Tsz-Wo >> >>
