bshashikant commented on a change in pull request #134:
URL: https://github.com/apache/incubator-ratis/pull/134#discussion_r443309101
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -118,6 +121,8 @@
this.jmxAdapter = new RaftServerJmxAdapter();
this.leaderElectionMetrics =
LeaderElectionMetrics.getLeaderElectionMetrics(this);
this.raftServerMetrics = RaftServerMetrics.getRaftServerMetrics(this);
+
+ this.finishStart = new AtomicBoolean(false);
Review comment:
Thanks @runzhiwang for discovering and providing this fix. This is one
of main reasons of several unit test failures.
The patch looks good to me.
Can we rename "finishStart" to something like startComplete or startDone?
"finishStart" looks confusing tome. Can you also add a comment in the code why
its important?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
