Looks like jira updates for Rave still sent to the incubator list. - Henry
On Fri, Mar 23, 2012 at 8:55 AM, Dennis Laan, van der <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4468/ > ----------------------------------------------------------- > > (Updated 2012-03-23 15:55:22.362174) > > > Review request for rave. > > > Changes > ------- > > Added issue number to summary > > > Summary (updated) > ------- > > An optional attribute for the ModulePrefs element in a gadget definition is > 'height', which states the static or default height of a gadget. Rave > currently has a default height of 250px, which is added to the iframe element > in which a gadget is created. It does not check if a height attribute is set > on the gadget to render. > Because iGoogle supports the height attribute and a lot of available gadgets > set their height statically, it would be a nice feature for Rave to support > the height attribute as well. > > > This addresses bug RAVE-526. > https://issues.apache.org/jira/browse/RAVE-526 > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528 > > Diff: https://reviews.apache.org/r/4468/diff > > > Testing > ------- > > Tested on gadgets: > - without height attribute and without dynamic height, > - without height and with dynamic height, > - with height and without dynamic height, > - with height and with dynamic height > > > Thanks, > > Dennis >
