>-----Original Message----- >From: Ate Douma [mailto:[email protected]] >Sent: Wednesday, March 28, 2012 5:11 PM >To: [email protected] >Subject: [DISCUSS] (RAVE-524) Move Rave-shindig > >On 03/22/2012 10:34 PM, Matt Franklin (Created) (JIRA) wrote: >> Move Rave-shindig >> ----------------- >> >> Key: RAVE-524 >> URL: https://issues.apache.org/jira/browse/RAVE-524 >> Project: Rave >> Issue Type: Technical task >> Reporter: Matt Franklin >> >> >> Create the following structure: >> >> rave-opensocial-provider >> |__rave-opensocial-core >> |__rave-opensocial-client >> |__rave-opensocial-server >> |_ rave-shindig >> >This new structure works and technically there is nothing wrong with it either, >but it isn't clear to me why we need rave-opensocial-server and rave-shindig, >nested under rave-opensocial-provider? > >At least right now I see no added value (yet) nor a logical/functional reason >as >neither the rave-opensocial-provider nor the rave-opensocial-server bring >any >(maven/pom) added value. > >Maybe I'm missing something obvious here but can't we keep rave-shindig >and >rave-portal as sibling root modules? Both are very similar IMO, as pom only >war >modules, aggregating everything else in and only needed in the last build >phase. >
IMO, the new structure simplifies the codebase from a logical perspective. Why have a rave-opensocial-provider separate from rave-shindig? Isn't Shindig part of the opensocial provider for Rave? If we begin expanding on Wookie to have rave customizations, wouldn't it make sense to keep them under the rave-w3c-provider structure? Another reason I thought it would be a good idea is that when we break shindig into rave-shindig-resources, rave-shindig-dependencies, rave-shindig, it pollutes the top level project structure. On the other hand, if there is a different model that makes more sense, I am not opposed to it... >And when overriding/extending rave for custom builds, typically neither >rave-portal nor rave-shindig will be used anymore but replaced with custom >war >modules, so from that perspective these are kind of 'example' modules. > >Ate
