----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4880/ -----------------------------------------------------------
Review request for rave. Summary ------- I pulled the "menubar" code out of page.jsp and put it into common/menubar.jsp to support easier customization for users. I added an optional attribute to the base-layout to support this additional field and added it to the tile-def for standard pages. Something similar might be done for profile and store in the future but they can't use this exact JSP since their menu options differ from normal pages. Diffs ----- /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/common/menubar.jsp PRE-CREATION /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1330602 /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1330602 /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1330602 Diff: https://reviews.apache.org/r/4880/diff Testing ------- Ran portal and witnessed no problems. Thanks, Chris
