-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4930/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Refactored the common navbar components to the header.tag file and included
that in all relevant jsp files (except mobile). I also expanded the
NavigationItem code to handle parameters for the navigation item text. Moved
menu generation code to the ControllerUtils class. This should eventually be
loaded from a DB per ticket RAVE-589
This addresses bug RAVE-586.
https://issues.apache.org/jira/browse/RAVE-586
Diffs
-----
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java
1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java
1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java
1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java
1331506
/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationItemTest.java
1331506
/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationMenuTest.java
1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp
1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp
1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp
1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag 1331506
Diff: https://reviews.apache.org/r/4930/diff
Testing
-------
Went through all screens to verify items showed as expected and had the correct
links.
Thanks,
Chris
