>-----Original Message----- >From: Raminder Singh [mailto:[email protected]] >Sent: Friday, May 04, 2012 2:06 PM >To: Fernando Pinhati; rave; Raminder Singh >Subject: Re: Review Request: [Rave-599] OpenSocial query for listing viewer >friends returns always zero results > > > >> On 2012-05-02 19:35:56, Raminder Singh wrote: >> > You need to change the unit test also. Current unit test are broken after i >applied the patch. Share a test gadget also if you have it hosted some place. >> >> Fernando Pinhati wrote: >> I have a test gadget at: http://mozart- >gadgets.appspot.com/dev/friendslist.xml >> I'm working on the unit tests. > >I saw there are few more problems like rave API to populate Friend model >etc. We may need to change getUniqueListOfConnectedPeople() also. I am >going to dig little deeper to find Rave integration to social data.
There is definitely a lot of work to start pushing forward in this area. Let's start picking up on the discussion points Ate raised, and add one for this if it isn't covered. I don’t think these activities are a barrier to application of Fernando's patch though... > > >- Raminder > > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/4965/#review7485 >----------------------------------------------------------- > > >On 2012-05-04 17:15:00, Fernando Pinhati wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/4965/ >> ----------------------------------------------------------- >> >> (Updated 2012-05-04 17:15:00) >> >> >> Review request for rave. >> >> >> Summary >> ------- >> >> Issue: >> https://issues.apache.org/jira/browse/RAVE-599 >> >> Fixed passing username instead of userId to PersonRepository findFriends >method. >> >> >> Diffs >> ----- >> >> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial- >core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPerson >Service.java 1333183 >> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial- >core/src/test/java/org/apache/rave/opensocial/service/PersonServiceTest.ja >va 1333183 >> >> Diff: https://reviews.apache.org/r/4965/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Fernando >> >>
