> On 2012-05-21 12:38:35, Aaron Gooch wrote: > > > > Chris Geer wrote: > Aaron, were you able to apply the patch? When I apply it on a fresh > checkout I get errors. > > patching file rave-portal-resources/pom.xml > patching file rave-portal-resources/src/main/resources/wro.xml > Hunk #1 FAILED at 23. > 1 out of 1 hunk FAILED -- saving rejects to file > rave-portal-resources/src/main/resources/wro.xml.rej > patching file > rave-portal-resources/src/main/webapp/WEB-INF/tags/navbar.tag > patching file > rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_css.tag > Hunk #1 FAILED at 19. > 1 out of 1 hunk FAILED -- saving rejects to file > rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_css.tag.rej > patching file rave-portal-resources/src/main/webapp/css/default.css > patching file rave-portal-resources/src/main/webapp/css/rave-css.less > patching file rave-portal-resources/src/main/webapp/css/rave.css > patching file rave-portal-resources/src/main/webapp/css/rave.less > Hunk #1 FAILED at 15. > Hunk #2 FAILED at 35.
I was able to apply the patch ok (using IntelliJ) although I tend to have better luck using TortoiseSVN in general. Anyhow I will apply Stan's patch. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5158/#review8009 ----------------------------------------------------------- On 2012-05-18 15:06:52, Stan Drozdetski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5158/ > ----------------------------------------------------------- > > (Updated 2012-05-18 15:06:52) > > > Review request for rave. > > > Summary > ------- > > An attempt to clean up the CSS after the Bootstrap implementation: > - "core" customizations have been moved into rave-css.less; this will make > reuse easier (e.g., inside widget stylesheets) > - a bit of cleanup was done to remove styles that are no longer needed > post-Bootstrap (more work is needed) > - default.css and rave.css are deleted > - the result of LESS processing is now called rave.css (instead of > rave-css.css) > > > Diffs > ----- > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/pom.xml > 1340120 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/wro.xml > 1340120 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/navbar.tag > 1340120 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_css.tag > 1340120 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/default.css > 1340120 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/rave-css.less > PRE-CREATION > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/rave.css > 1340120 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/rave.less > 1340120 > > Diff: https://reviews.apache.org/r/5158/diff > > > Testing > ------- > > > Thanks, > > Stan > >
