----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5617/#review9075 -----------------------------------------------------------
Ship it! LGTM - will make a couple minor changes with patch: 1) change .entityId property references to .id (now that we are using interface based model pattern, no guarantee of .entityId field existing) 2) page.widget.rate.likebtn message key was being used twice, instead of .dislikebtn - Anthony Carlucci On July 11, 2012, 5:17 p.m., Kristen Legacy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5617/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 5:17 p.m.) > > > Review request for rave. > > > Description > ------- > > Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle > button/count sizing instead of reconfiguring how button & count function, > which has the handy side effect of preventing the button from being > substantially smaller than the like count text above it. > > https://issues.apache.org/jira/browse/RAVE-683 > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/resources/messages.properties 1360225 > trunk/rave-portal-resources/src/main/resources/messages_es.properties > 1360225 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1360225 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp > 1360225 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp > 1360225 > trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less > 1360225 > trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js > 1360225 > > Diff: https://reviews.apache.org/r/5617/diff/ > > > Testing > ------- > > > Thanks, > > Kristen Legacy > >
