> On Aug. 7, 2012, 10:06 p.m., Chris Geer wrote: > > trunk/rave-portal-resources/src/main/webapp/static/script/rave.js, line 1287 > > <https://reviews.apache.org/r/6444/diff/1/?file=135322#file135322line1287> > > > > Does it make sense to update the documentation here to describe the > > expected/returned object?
I think no? First, that's not consistent with all of the other documentation comments in the file. Second, this is providing a reference implementation, but the pageOwner / pageViewer objects could contain any custom object based on the user implementation. - Erin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6444/#review9993 ----------------------------------------------------------- On Aug. 8, 2012, 1:15 p.m., Erin Noe-Payne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6444/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 1:15 p.m.) > > > Review request for rave. > > > Description > ------- > > Adds the concept of page viewer and owner to the client at the container > level. Page viewer is defined as the authenticated user viewing a page, owner > is left to be defined on a per-page basis. > > > This addresses bug RAVE-751. > https://issues.apache.org/jira/browse/RAVE-751 > > > Diffs > ----- > > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp > 1370376 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag > 1370376 > trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376 > > Diff: https://reviews.apache.org/r/6444/diff/ > > > Testing > ------- > > > Thanks, > > Erin Noe-Payne > >
