----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7388/#review12105 -----------------------------------------------------------
Ship it! LGTM - will fix comment when I apply patch trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag <https://reviews.apache.org/r/7388/#comment25790> minor nit - comment should use "widget", not "opensocial gadget" - Anthony Carlucci On Oct. 2, 2012, 12:13 p.m., Daniel Gornstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7388/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2012, 12:13 p.m.) > > > Review request for rave. > > > Description > ------- > > Allow setting of default widget height through preference section of admin > panel > > > Diffs > ----- > > > trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java > 1392387 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java > 1392387 > trunk/rave-portal-resources/src/main/resources/messages.properties 1392387 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql > 1392387 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferencedetail.jsp > 1392387 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag > 1392387 > trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1392387 > > trunk/rave-portal-resources/src/main/webapp/static/script/rave_opensocial.js > 1392387 > trunk/rave-portal-resources/src/main/webapp/static/script/rave_wookie.js > 1392387 > > Diff: https://reviews.apache.org/r/7388/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gornstein > >
