Ok, I lie. I did the PR. I think it is perfect now (well perfectly fixing the JS error but not the preview issue).
On Sat, Mar 15, 2014 at 10:07 PM, Raymond Camden <[email protected]>wrote: > I'm going to have to punt as I don't have time to fight w/ Git. Is anyone > else willing to make the PR? As I said, it is one line, *very* small, heck, > I'll send you the file. Just let me know. > > > On Fri, Mar 14, 2014 at 11:47 AM, Raymond Camden > <[email protected]>wrote: > >> Ugh - I hate Git sometimes. ;) I'll try again later tonight - going to >> training for a week w/ limited net access at night. If anyone else on this >> thread wants to 'steal' my fix and submit a PR, by my guest. :) >> >> >> On Fri, Mar 14, 2014 at 11:11 AM, Brent Lintner >> <[email protected]>wrote: >> >>> Hey Raymond, >>> >>> No exactly too sure what your issue looks like, but using `git rebase` >>> (against next branch) should solve that, I would suspect (or guess)? >>> >>> >>> On Thu, Mar 13, 2014 at 5:12 PM, Raymond Camden <[email protected] >>> >wrote: >>> >>> > Lame Git question. For some reason the PR I just made has diffs from >>> the >>> > *earlier* PR I made. How can I fix that? >>> > >>> > >>> > On Thu, Mar 13, 2014 at 11:32 AM, Brent Lintner < >>> [email protected] >>> > >wrote: >>> > >>> > > A PR would be awesome- thanks Raymond. >>> > > >>> > > >>> > > On Wed, Mar 12, 2014 at 9:00 PM, Raymond Camden < >>> [email protected] >>> > > >wrote: >>> > > >>> > > > I see this has been reported already as well ( >>> > > > https://issues.apache.org/jira/browse/ripple). I'd be happy to >>> submit >>> > a >>> > > PR >>> > > > just to get this part way fixed at least. >>> > > > >>> > > > >>> > > > On Wed, Mar 12, 2014 at 7:46 PM, Raymond Camden < >>> > [email protected] >>> > > > >wrote: >>> > > > >>> > > > > Did some debugging. I changed >>> > > > > >>> > > > > camera.js, line 51 to >>> > > > > >>> > > > > capture.setAttribute("controls",true); >>> > > > > >>> > > > > This fixed the bug, but the preview we used to get no longer >>> works. >>> > > > > >>> > > > > I can submit a pull request with this fix, but obviously it was >>> just >>> > a >>> > > > > guess. Maybe Chrome recently got more strict about setAttribute. >>> > > > > >>> > > > > >>> > > > > On Wed, Mar 12, 2014 at 7:35 PM, Raymond Camden < >>> > > [email protected] >>> > > > >wrote: >>> > > > > >>> > > > >> Using the Camera API in the latest Cordova, Ripple, I get this >>> in >>> > > > console >>> > > > >> after selecting an image: >>> > > > >> >>> > > > >> Uncaught TypeError: Failed to execute 'setAttribute' on >>> 'Element': 2 >>> > > > >> arguments required, but only 1 present. >>> > > > >> >>> > > > >> ripple.js:49275 >>> > > > >> >>> > > > >> -- >>> > > > >> >>> > > > >> >>> > > > >>> > > >>> > >>> =========================================================================== >>> > > > >> Raymond Camden, Web Developer for Adobe >>> > > > >> >>> > > > >> Email : [email protected] >>> > > > >> Blog : www.raymondcamden.com >>> > > > >> Twitter: cfjedimaster >>> > > > >> >>> > > > > >>> > > > > >>> > > > > >>> > > > > -- >>> > > > > >>> > > > >>> > > >>> > >>> =========================================================================== >>> > > > > Raymond Camden, Web Developer for Adobe >>> > > > > >>> > > > > Email : [email protected] >>> > > > > Blog : www.raymondcamden.com >>> > > > > Twitter: cfjedimaster >>> > > > > >>> > > > >>> > > > >>> > > > >>> > > > -- >>> > > > >>> > > >>> > >>> =========================================================================== >>> > > > Raymond Camden, Web Developer for Adobe >>> > > > >>> > > > Email : [email protected] >>> > > > Blog : www.raymondcamden.com >>> > > > Twitter: cfjedimaster >>> > > > >>> > > >>> > > >>> > > >>> > > -- >>> > > Brent Lintner >>> > > >>> > >>> > >>> > >>> > -- >>> > >>> =========================================================================== >>> > Raymond Camden, Web Developer for Adobe >>> > >>> > Email : [email protected] >>> > Blog : www.raymondcamden.com >>> > Twitter: cfjedimaster >>> > >>> >>> >>> >>> -- >>> Brent Lintner >>> >> >> >> >> -- >> >> =========================================================================== >> Raymond Camden, Web Developer for Adobe >> >> Email : [email protected] >> Blog : www.raymondcamden.com >> Twitter: cfjedimaster >> > > > > -- > =========================================================================== > Raymond Camden, Web Developer for Adobe > > Email : [email protected] > Blog : www.raymondcamden.com > Twitter: cfjedimaster > -- =========================================================================== Raymond Camden, Web Developer for Adobe Email : [email protected] Blog : www.raymondcamden.com Twitter: cfjedimaster
