[ 
https://issues.apache.org/jira/browse/RIPPLE-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957118#comment-13957118
 ] 

Brent Lintner commented on RIPPLE-15:
-------------------------------------

Ah, good point. I am sure that could be done (given it is OK with any ASF 
guidelines).

I was going to say you are welcome to do this yourself (although we should 
create a discussion thread in the mailing list first).... however: I just 
remembered that the Chrome Extension got removed some time ago (to greatly 
simplify build processes, the project itself, and to focus support on injecting 
Ripple with a feature-full webserver, which had been a long time goal)..

https://github.com/apache/incubator-ripple/commit/a5287cc8f6345d776c00ae26268540c3c0683bc8

The target files appear to still be there though (which threw me off)... :-s

Is the Chrome Extension giving you something that the NPM package cannot?

> Touch Events emulation: emulated 'touchend' event has touch in 'touches' field
> ------------------------------------------------------------------------------
>
>                 Key: RIPPLE-15
>                 URL: https://issues.apache.org/jira/browse/RIPPLE-15
>             Project: Apache Ripple
>          Issue Type: Bug
>         Environment: Window 8 64bit;
> Chrome 26.0.1410.64 m;
> Ripple Emulator (Beta) 0.9.15
>            Reporter: Alexander Ziborov
>            Assignee: Dan Silivestru
>              Labels: events, javascript, simulation
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The 'touchend' event emulated by 'mouseup' should contain empty 'touches' and 
> 'targetTouches' lists, but actually it has one touch.
> For example, Chrome mode "Emulate touch events" works as expected - 
> 'touchend' event have no any touch in 'touches' and 'targetTouches'. Mobile 
> devices so work also.
> Potential issue is in this part of the code, as I think: 
> incubator-ripple-HEAD-24cae31\lib\client\touchEventEmulator.js
> function _simulateTouchEvent(type, mouseevent) {
>     ...
>         changedTouches: [touchObj],
>         targetTouches: [touchObj],
>         touches: [touchObj]
>     ...
> }
> As one of the potential solutions, I suggest to check for 'touchend' event 
> type, something like this:
>   ...
>     targetTouches: type === "touchend" ? [] : [touchObj],
>     touches: type === "touchend" ? [] : [touchObj]
>   ....



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to