Jason918 commented on issue #220: [ROCKETMQ-332] MappedFileQueue#findMappedFileByOffset is not thread safe, which will cause message loss. URL: https://github.com/apache/rocketmq/pull/220#issuecomment-359154803 @zhouxinyu All of your question applies to all the optimistic locking implementation, right? For most cases, the deletion of one `mappedFileQueue` does not happen concurrently, either in CleanConsumeQueueService or CleanCommitLogService, so I think the probability of multi-retries is very small. So in my fix of this issue, I did retries up to 3 times in a for loop. If it still fails after 3 times, I would do the iteration. After several days of test running, it all succeed in the second time (first retries). I will upload my code in the following days. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
