dongeforever commented on a change in pull request #798: [issue#790]fix
defaultTopicPerm and defaultGroupPerm values which are in yaml config file
dosen't work.
URL: https://github.com/apache/rocketmq/pull/798#discussion_r257564145
##########
File path:
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionLoader.java
##########
@@ -130,8 +130,8 @@ void checkPerm(PlainAccessResource needCheckedAccess,
PlainAccessResource ownedA
if (!ownedPermMap.containsKey(resource)) {
// Check the default perm
- byte ownedPerm = isGroup ?
needCheckedAccess.getDefaultGroupPerm() :
- needCheckedAccess.getDefaultTopicPerm();
+ byte ownedPerm = isGroup ? ownedAccess.getDefaultGroupPerm() :
+ ownedAccess.getDefaultTopicPerm();
if (!Permission.checkPermission(neededPerm, ownedPerm)) {
throw new AclException(String.format("No default
permission for %s", PlainAccessResource.printStr(resource, isGroup)));
Review comment:
Great Catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
