dongeforever commented on a change in pull request #751: [RIP-7] Multiple
Directories Storage Support
URL: https://github.com/apache/rocketmq/pull/751#discussion_r258844605
##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -64,8 +64,16 @@
private final PutMessageLock putMessageLock;
public CommitLog(final DefaultMessageStore defaultMessageStore) {
- this.mappedFileQueue = new
MappedFileQueue(defaultMessageStore.getMessageStoreConfig().getStorePathCommitLog(),
-
defaultMessageStore.getMessageStoreConfig().getMapedFileSizeCommitLog(),
defaultMessageStore.getAllocateMappedFileService());
+ if
(defaultMessageStore.getMessageStoreConfig().isMultiCommitLogPathEnable()) {
+ this.mappedFileQueue = new
MultiPathMappedFileQueue(defaultMessageStore.getMessageStoreConfig(),
+
defaultMessageStore.getMessageStoreConfig().getMapedFileSizeCommitLog(),
+ defaultMessageStore.getAllocateMappedFileService());
+ } else {
+ this.mappedFileQueue = new
MappedFileQueue(defaultMessageStore.getMessageStoreConfig().getStorePathCommitLog(),
+
defaultMessageStore.getMessageStoreConfig().getMapedFileSizeCommitLog(),
Review comment:
No need to introduce isMultiCommitlogPathEnable.
Just check whether the old storePathCommitlog has path seperator ',' or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
