duhenglucky commented on a change in pull request #842: [RIP-11]MQTT:completing
pub and sub logic of qos=0 messages(single node only )
URL: https://github.com/apache/rocketmq/pull/842#discussion_r258920334
##########
File path: snode/src/main/java/org/apache/rocketmq/snode/SnodeController.java
##########
@@ -309,48 +319,57 @@ private void initSnodeInterceptorGroup() {
}
- public void registerProcessor() {
- this.snodeServer.registerProcessor(RequestCode.SEND_MESSAGE_V2,
sendMessageProcessor,
- this.sendMessageExecutor);
- this.snodeServer.registerProcessor(RequestCode.CONSUMER_SEND_MSG_BACK,
sendMessageProcessor,
- this.sendMessageExecutor);
- this.snodeServer.registerProcessor(RequestCode.HEART_BEAT,
heartbeatProcessor,
- this.heartbeatExecutor);
- this.snodeServer.registerProcessor(RequestCode.UNREGISTER_CLIENT,
heartbeatProcessor,
- this.heartbeatExecutor);
- this.snodeServer.registerProcessor(RequestCode.CHECK_CLIENT_CONFIG,
heartbeatProcessor,
- this.heartbeatExecutor);
- this.snodeServer.registerProcessor(RequestCode.SNODE_PULL_MESSAGE,
pullMessageProcessor,
- this.pullMessageExecutor);
- this.snodeServer
- .registerProcessor(RequestCode.GET_CONSUMER_LIST_BY_GROUP,
consumerManageProcessor,
- this.consumerManageExecutor);
- this.snodeServer
- .registerProcessor(RequestCode.UPDATE_CONSUMER_OFFSET,
consumerManageProcessor,
+ private void registerProcessor() {
+ if(snodeServer != null) {
+ this.snodeServer.registerProcessor(RequestCode.SEND_MESSAGE_V2,
sendMessageProcessor,
Review comment:
Please don't change the code format if we have no change about this, it will
lead us difficult to review these codes later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
