duhenglucky commented on a change in pull request #633: [ISSUE #598] Enhance
transaction by putting messages that exceed max check times to system topic
URL: https://github.com/apache/rocketmq/pull/633#discussion_r264072171
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -214,14 +228,18 @@ public boolean rejectRequest() {
}
private synchronized RemotingCommand
updateAndCreateTopic(ChannelHandlerContext ctx,
- RemotingCommand request) throws RemotingCommandException {
+ RemotingCommand request) throws RemotingCommandException {
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
final CreateTopicRequestHeader requestHeader =
- (CreateTopicRequestHeader)
request.decodeCommandCustomHeader(CreateTopicRequestHeader.class);
- log.info("updateAndCreateTopic called by {}",
RemotingHelper.parseChannelRemoteAddr(ctx.channel()));
-
- if
(requestHeader.getTopic().equals(this.brokerController.getBrokerConfig().getBrokerClusterName()))
{
- String errorMsg = "the topic[" + requestHeader.getTopic() + "] is
conflict with system reserved words.";
+ (CreateTopicRequestHeader) request
Review comment:
If no other changes, please don't reformat the code :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
