[GitHub] [rocketmq] ChaosYjh opened a new issue #1241: 应该尽量减少客户端不必要的三方包引用

[GitBox]

ChaosYjh opened a new issue #1241: 应该尽量减少客户端不必要的三方包引用
URL: https://github.com/apache/rocketmq/issues/1241
 
 
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
我认为rocketmq应该尽量减少客户端不必要的包引用以降低包冲突的风险。如下图一，客户端在添加acl支持的时候，所引用的guava包，仅仅在org.apache.rocketmq.srvutil.FileWatchService#FileWatchService里被用来做字符串的空判断（图二），其实完全可以用common模块所引用的commons-lang3包里的StringUtils.isNotEmpty来替代，并把guava包的引用放到filter模块里。这样用户在使用rocketmq客户端的时候就减少了不必要的guava依赖
   <img width="858" alt="屏幕快照 2019-06-03 08 57 19" 
src="https://user-images.githubusercontent.com/27771595/58770014-c7a19480-85de-11e9-93c5-9bcad17f01d1.png";>
   <img width="666" alt="image" 
src="https://user-images.githubusercontent.com/27771595/58770094-675f2280-85df-11e9-8d78-2fa219d244e8.png";>
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   **blocker**
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services