zongtanghu commented on issue #1217: [ISSUE #1156]new mqadmin API for ACL 
configuration
URL: https://github.com/apache/rocketmq/pull/1217#issuecomment-501697151
 
 
   > @zongtanghu Another thing, If I could figure out what's you have doing in 
this pr, I would like to help to merge the pr. But. please remember, consider 
this change almost over 40 files. It's not a good practice to review and merge 
model. could you make a smaller pr, just less than 10 files affected in the 
next time?
   
   Okay,This PR is too much large.I will remember the rule of puting forward pr 
for rocketmq source community.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to