vongosling commented on a change in pull request #1249: Add unit tests for
org.apache.rocketmq.common.UtilAll
URL: https://github.com/apache/rocketmq/pull/1249#discussion_r293648232
##########
File path: common/pom.xml
##########
@@ -37,5 +37,16 @@
<groupId>${project.groupId}</groupId>
<artifactId>rocketmq-remoting</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.powermock</groupId>
+ <artifactId>powermock-api-mockito</artifactId>
+ <version>1.6.6</version>
Review comment:
Have you noticed the dependency mockito in the parent pom? powermock is a
good extension for mockito. I strongly recommend that you could move the
dependency into parent pom and scope it in the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
