odbozhou commented on a change in pull request #1240: [ISSUE #1199] Implement 
the 1.0.0 openmessaging new consumer API for rocketmq oms module
URL: https://github.com/apache/rocketmq/pull/1240#discussion_r294090218
 
 

 ##########
 File path: 
openmessaging/src/test/java/io/openmessaging/rocketmq/consumer/PullConsumerImplTest.java
 ##########
 @@ -88,6 +103,94 @@ public void testPoll() {
         Message message = pullConsumer.receive(3 * 1000);
         assertThat(message.header().getMessageId()).isEqualTo("NewMsgId");
         assertThat(message.getData()).isEqualTo(testBody);
+
+        List<MessageExt> messageExts = new ArrayList<MessageExt>() {
+            {
+                add(consumedMsg);
+            }
+        };
+        PullResult pullResult = new PullResult(PullStatus.FOUND, 11, 1, 100, 
messageExts);
+        
doReturn(pullResult).when(rocketmqPullConsumer).pull(any(MessageQueue.class), 
anyString(), anyLong(), anyInt(), anyLong());
+        MessageQueue messageQueue = new MessageQueue(queueName, "breakeName", 
0);
+        Set<MessageQueue> messageQueues = new HashSet<MessageQueue>() {
+            {
+                add(messageQueue);
+            }
+        };
+        
doReturn(messageQueues).when(rocketmqPullConsumer).fetchSubscribeMessageQueues(queueName);
+        QueueMetaData queueMetaData = new DefaultQueueMetaData(queueName, 0);
+        MessageReceipt messageReceipt = new DefaultMessageReceipt("NewMsgId", 
10L);
+        long timeout = 3000L;
+        Message message1 = pullConsumer.receive(queueName, queueMetaData, 
messageReceipt, timeout);
+        assertThat(message1.header().getMessageId()).isEqualTo("NewMsgId");
+        assertThat(message1.getData()).isEqualTo(testBody);
+    }
+
+    @Test
+    public void testBatchPoll() throws InterruptedException, 
RemotingException, MQClientException, MQBrokerException {
+        final byte[] testBody = new byte[] {'a', 'b'};
+        MessageExt consumedMsg = new MessageExt();
+        consumedMsg.setMsgId("NewMsgId");
+        consumedMsg.setBody(testBody);
+        consumedMsg.putUserProperty(NonStandardKeys.MESSAGE_DESTINATION, 
"TOPIC");
+        consumedMsg.setTopic(queueName);
+        consumedMsg.setQueueId(0);
+        consumedMsg.setStoreHost(new InetSocketAddress("127.0.0.1", 9876));
+        final byte[] testBody1 = new byte[] {'c', 'd'};
+        MessageExt consumedMsg1 = new MessageExt();
+        consumedMsg1.setMsgId("NewMsgId1");
+        consumedMsg1.setBody(testBody1);
+        consumedMsg1.putUserProperty(NonStandardKeys.MESSAGE_DESTINATION, 
"TOPIC");
+        consumedMsg1.setTopic(queueName);
+        consumedMsg1.setQueueId(0);
+        consumedMsg1.setStoreHost(new InetSocketAddress("127.0.0.1", 9876));
+        List<MessageExt> messageExts = new ArrayList<MessageExt>() {
+            {
+                add(consumedMsg);
+                add(consumedMsg1);
+            }
+        };
+        
doReturn(messageExts).when(localMessageCache).batchPoll(any(KeyValue.class));
+        List<Message> messages = pullConsumer.batchReceive(3 * 1000);
+
+        Message message1 = null;
+        Message message2 = null;
+        assertThat(messages.size()).isEqualTo(2);
+        for (Message message : messages) {
+            if (message.header().getMessageId().equals("NewMsgId")) {
+                message1 = message;
+            }
+            if (message.header().getMessageId().equals("NewMsgId1")) {
+                message2 = message;
+            }
+        }
+        assertThat(message1).isNotNull();
 
 Review comment:
   This has increased verification

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to