ShannonDing commented on a change in pull request #2: Call onException instead
when async sending with NULL topic
URL: https://github.com/apache/rocketmq-ons/pull/2#discussion_r294206432
##########
File path:
ons-core/ons-client/src/main/java/org/apache/rocketmq/ons/api/impl/rocketmq/ProducerImpl.java
##########
@@ -169,7 +169,13 @@ public void sendAsync(Message message, SendCallback
sendCallback) {
message.setMsgID(MessageClientIDSetter.getUniqID(msgRMQ));
} catch (Exception e) {
LOGGER.error(String.format("Send message async Exception, %s",
message), e);
- throw checkProducerException(message.getTopic(),
message.getMsgID(), e);
+ //throw checkProducerException(message.getTopic(),
message.getMsgID(), e);
Review comment:
Done. Keeping runtime exception here is much better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
