zhangjidi2016 commented on a change in pull request #2376:
URL: https://github.com/apache/rocketmq/pull/2376#discussion_r512427608
##########
File path: common/src/main/java/org/apache/rocketmq/common/UtilAll.java
##########
@@ -461,33 +461,9 @@ private static boolean ipCheck(byte[] ip) {
if (ip.length != 4) {
Review comment:
As a utility class method, I think this judgment code is necessary to
exclude illegal IPV4 addresses in the first place. Regarding other method
optimizations for this class, I will submit other PR in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
