zhangjidi2016 commented on a change in pull request #7: URL: https://github.com/apache/rocketmq-dashboard/pull/7#discussion_r690842785
########## File path: src/main/java/org/apache/rocketmq/dashboard/controller/LoginController.java ########## @@ -65,10 +66,10 @@ public Object check(HttpServletRequest request) { @RequestMapping(value = "/login.do", method = RequestMethod.POST) @ResponseBody - public JsonResult<String> login(@RequestParam("username") String username, - @RequestParam(value = "password") String password, - HttpServletRequest request, - HttpServletResponse response) throws Exception { + public Object login(@RequestParam("username") String username, Review comment: When the interface returns, the returned object is processed and wrapped into a JsonResult by GlobalRestfulResponseBodyAdvice, consistent with other interface returns in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org