liuxuzxx commented on a change in pull request #3386:
URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720616493



##########
File path: 
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java
##########
@@ -17,11 +17,17 @@
 package org.apache.rocketmq.remoting.protocol;
 
 import com.alibaba.fastjson.JSON;
+import com.alibaba.fastjson.serializer.SerializerFeature;
+
 import java.nio.charset.Charset;
 
 public abstract class RemotingSerializable {
     private final static Charset CHARSET_UTF8 = Charset.forName("UTF-8");
 
+    static {

Review comment:
       
ok,我感觉这个最大的隐患可能是broker和namesrv是否需要同时设置SerializerFeature.WriteNonStringKeyAsString的问题,我在低版本的fastjson1.2.58好像,是必须同时设置的!如果最新版本的fastjson也需要同时设置,那就真得两边同时修改了!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to