[GitHub] [rocketmq] XiaoyiPeng edited a comment on pull request #3788: [ISSUE #3786] fix: The length of properties value should be checked before converting them to short.

[GitBox]

XiaoyiPeng edited a comment on pull request #3788:
URL: https://github.com/apache/rocketmq/pull/3788#issuecomment-1021848547


   > Whether to add more information to the RuntimeException message, such as 
the current prop length, limit length...
   
   Thanks for your advice, I've corrected it.
   
   For commit in class `CommitLog`, in order to keep the **code style 
consistent**, the properties length limit is only recorded in the log, and the 
exception message is consistent with the code style below: 
   
   
![image](https://user-images.githubusercontent.com/8653312/151103626-5472182a-1b2f-4229-ac93-672dac1686d7.png)
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org