RongtongJin commented on a change in pull request #3759:
URL: https://github.com/apache/rocketmq/pull/3759#discussion_r814552265
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
##########
@@ -239,6 +243,8 @@ public void start() throws MQClientException {
this.pullMessageService.start();
// Start rebalance service
this.rebalanceService.start();
+ //Start heartbeat service
+ this.heartbeatService.start();
Review comment:
no shutdown heartbeatService when MQClientInstance shutdown
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
##########
@@ -239,6 +243,8 @@ public void start() throws MQClientException {
this.pullMessageService.start();
// Start rebalance service
this.rebalanceService.start();
+ //Start heartbeat service
+ this.heartbeatService.start();
Review comment:
no shutdown heartbeatService thread when the MQClientInstance shutdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
