RongtongJin commented on code in PR #4341:
URL: https://github.com/apache/rocketmq/pull/4341#discussion_r876982262
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -1637,6 +1638,21 @@ protected void sendHeartbeat() {
this.brokerConfig.getSendHeartbeatTimeoutMillis(),
this.brokerConfig.isInBrokerContainer());
}
+ // If in controller mode and the controller is deployed independently
+ if (this.brokerConfig.isStartupControllerMode() &&
this.brokerConfig.isControllerDeployedStandAlone()) {
+ final String controllerLeaderAddress =
this.replicasManager.getControllerLeaderAddress();
+ if (StringUtils.isNotEmpty(controllerLeaderAddress)) {
+ this.brokerOuterAPI.sendHeartbeatToController(
+ controllerLeaderAddress,
Review Comment:
We should send heartbeats to all controllers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
