XiaoyiPeng opened a new issue, #4349:
URL: https://github.com/apache/rocketmq/issues/4349
**BUG REPORT**
1. Please describe the issue you observed:
Hi, @cserwen , In PR #4281, you reminded me of the risk of method
`Math.abs(int a)`, which might return a negative number.
I found this risk elsewhere as well，as shown below:
https://github.com/apache/rocketmq/blob/82a48be00a6d9def14abb871a40cb68cf8a041e9/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java#L79-L80
https://github.com/apache/rocketmq/blob/82a48be00a6d9def14abb871a40cb68cf8a041e9/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java#L75-L77
I think it would be best to fix it !
2. Please tell us about your environment:
OS：MacOS Catalina.
branch: develop.
3. Other information (e.g. detailed explanation, logs, related issues,
suggestions on how to fix, etc):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
